set correct tsize option in server OACK when negotiating download

[zgyarmati]

Small patch, fixes
TftpServer reports incorrect tsize #45
please feel free to review and comment

[msoulier]

This looks like it's always going to send an oack with a tsize whether the client requested that option or not.

[zgyarmati]

Hm, true, i didn't consider this (in my usecase the client always sends tsize...). Will add and test this later today and resend, thanks!

[msoulier]

Did you get around to updating this? Otherwise I'll look at it.

[zgyarmati]

Thanks for pinging me, i pushed a fix, please feel free to comment

[msoulier]

Patch looks good. I just need to add a testcase for it.

[msoulier]

Hmm. New test cases are failing.

ERROR: testClientServerUploadTsize (main.TestTftpyState)

Traceback (most recent call last):
File "t/test.py", line 228, in testClientServerUploadTsize
self.clientServerUploadOptions({'tsize': 64*1024}, transmitname='/foo/bar/640KBFILE')
File "t/test.py", line 166, in clientServerUploadOptions
input)
File "/Users/msoulier/work/tftpy/tftpy/TftpClient.py", line 86, in upload
self.context.start()
File "/Users/msoulier/work/tftpy/tftpy/TftpContexts.py", line 298, in start
self.cycle()
File "/Users/msoulier/work/tftpy/tftpy/TftpContexts.py", line 190, in cycle
self.state = self.state.handle(recvpkt, raddress, rport)
File "/Users/msoulier/work/tftpy/tftpy/TftpStates.py", line 492, in handle
self.handleOACK(pkt)
File "/Users/msoulier/work/tftpy/tftpy/TftpStates.py", line 37, in handleOACK
if pkt.match_options(self.context.options):
File "/Users/msoulier/work/tftpy/tftpy/TftpPacketTypes.py", line 440, in match_options
raise TftpException, "Unsupported option: %s" % name
TftpException: Unsupported option: tsize