Skip to content

Commit

Permalink
Remove QuicChannelOption that is not used anymore (java-native-access…
Browse files Browse the repository at this point in the history
…#196)

Motivation:

Peer verification is now configured as part of the QuicSslContextBuilder. Remove the unused QuicChannelOption.

Modifications:

- Remove unused QuicChannelOption

Result:

Code cleanup
  • Loading branch information
normanmaurer authored Feb 19, 2021
1 parent 77fb5a8 commit d2ecdec
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,8 @@
*/
package io.netty.incubator.codec.quic;

import java.util.Map;

import io.netty.buffer.ByteBufAllocator;
import io.netty.channel.Channel;
import io.netty.channel.ChannelOption;
import io.netty.channel.DefaultChannelConfig;
import io.netty.channel.MessageSizeEstimator;
import io.netty.channel.RecvByteBufAllocator;
Expand All @@ -34,11 +31,6 @@ final class DefaultQuicChannelConfig extends DefaultChannelConfig implements Qui
super(channel);
}

@Override
public Map<ChannelOption<?>, Object> getOptions() {
return getOptions(super.getOptions(), QuicChannelOption.PEER_CERT_SERVER_NAME);
}

@Override
public QuicChannelConfig setConnectTimeoutMillis(int connectTimeoutMillis) {
super.setConnectTimeoutMillis(connectTimeoutMillis);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,6 @@
*/
public final class QuicChannelOption<T> extends ChannelOption<T> {

/**
* Optional parameter to verify peer's certificate.
* See <a href="https://docs.rs/quiche/0.6.0/quiche/fn.connect.html">server_name</a>.
*/
public static final ChannelOption<String> PEER_CERT_SERVER_NAME =
valueOf(QuicChannelOption.class, "PEER_CERT_SERVER_NAME");

/**
* If set to {@code true} the {@link QuicStreamChannel} will read {@link QuicStreamFrame}s and fire it through
* the pipeline, if {@code false} it will read {@link io.netty.buffer.ByteBuf} and translate the FIN flag to
Expand Down

0 comments on commit d2ecdec

Please sign in to comment.