Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287
I've removed the tight coupling between the text input and the value, which was also being limited by the min/max constraints.
This means that when you edit a numeric input, you can clear the input and type in a number larger or smaller than the allowable. When you save though, the value saved is the one entered which is in range. Hopefully if you try it you'll see what I mean.
For example, when editing a temperature (which has a minimum value of 1) this sequence can happen:
30
3
is saved, as this is the last valid valueIt is hard to explain but I think makes more sense when using it than the previous, which prevented the input value from changing.
The affected areas are:
You can test this and #296 with this apk