Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cold chain: Temperature logs are not synced from CCA to OMS while a breach is active #2537

Closed
2 of 5 tasks
adamdewey opened this issue Nov 23, 2023 · 5 comments · Fixed by #2589
Closed
2 of 5 tasks
Assignees
Labels
bug Something is borken
Milestone

Comments

@adamdewey
Copy link
Contributor

adamdewey commented Nov 23, 2023

What went wrong? 😲

Temperature logs are not coming across from CCA to OMS while there's an active breach on CCA.

As soon as the excursion is resolved i.e. returns below the threshold (note, not breach acknowledged), then log syncing resumes.

Observed on both tablet and Windows OMS.

CCA during active breach:

telegram-cloud-photo-size-1-5113892675039374097-y

OMS during active breach:

telegram-cloud-photo-size-1-5113892675039374098-y

Note: the breach duration threshold is 4 mins, so the first 2 logs (17:54:16 and 17:56:16) came across to OMS before they were flagged as part of a breach.

CCA after breach resolved:

telegram-cloud-photo-size-1-5113892675039374105-y

OMS after breach resolved:

telegram-cloud-photo-size-1-5113892675039374106-y

Expected behaviour 🤔

Logs should come through allll the time

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Sync CCA to OMS (tablet or Windows)
  2. Note logs coming through correctly
  3. Trigger an breach on a sensor
  4. Note that logs for that sensor stop coming through to OMS (other sensors will continue syncing as normal)
  5. Resolve the breach
  6. Note that logs start coming through again

Your environment 🌱

  • CCA version: 0.5.6-rc1
  • OMS Version: 1.5.02
  • Platform:
    • android (tablet)
    • browser (extra points if you tell us which one)
    • desktop (windows)
    • desktop (macOS)
    • server (windows)
@adamdewey adamdewey added bug Something is borken needs triage labels Nov 23, 2023
@mark-prins mark-prins self-assigned this Dec 4, 2023
@mark-prins
Copy link
Collaborator

unable to reproduce the issue with my local testing. am using the current develop branch of cold chain app with the current develop branch of omSupply. results show up in omSupply correctly whether in breach or not.

@adamdewey
Copy link
Contributor Author

I'm still getting this with CCA 0.5.6 and OMS 1.5.03 - maybe I can show you tomorrow @mark-prins ?

@adamdewey adamdewey reopened this Dec 14, 2023
@mark-prins
Copy link
Collaborator

thanks. will retest with 1.5.03 as well

@mark-prins mark-prins added this to the V1.6.0 milestone Dec 14, 2023
@DhanyaHerath DhanyaHerath modified the milestones: V1.6.0, V1.7.0 Feb 1, 2024
@mark-prins
Copy link
Collaborator

@jmbrunskill did a fix which might resolve this one

OMS PR #2913 which went in two weeks ago, so isn't in a build yet
and CCA PR #291

we should retest with those fixes in place

@nishaDangol-Sussol
Copy link

Have checked this with oms v1.6.2 exe and coldchain 0.5.6. I can see the logs even when the breach is active, looks fixed in v1.6.2! Can close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants