2720 cold chain missing data create temporary breaches #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
jmbrunskill
changed the base branch from
develop
to
2720-cold-chain-sometimes-graph-missing-sections
jmbrunskill
changed the title
Base automatically changed from
2720-cold-chain-sometimes-graph-missing-sections
to
develop
February 8, 2024 04:18
mark-prins
approved these changes
Feb 11, 2024
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2720
👩🏻💻 What does this PR do?
Creates temporary breach records if a temperature log references a breach that doesn't already exist.
This shouldn't be necessary with other code changes in CCA, but did solve a problem for me with breaches created before the app was integrated with Open-mSupply...
🧪 How has/should this change been tested?
💌 Any notes for the reviewer?
Should we include this code? Or just rely on the CCA app update?
I had to add Excusion to the frontend as a breach type, panic seemed to extreme a response to this!
📃 Documentation
No user facing changes