Fix simultaneous updates of multiple properties in "updateEntity" #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
force-pushed
the
fix-update-entity
branch
from
f8da518
to
e013fc2
Compare
kettanaito
changed the title
kettanaito
changed the title
kettanaito
force-pushed
the
fix-update-entity
branch
from
e013fc2
to
958f57b
Compare
kettanaito
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
Thank you for working on this, @yethee!
Your fix is spot-on and your tests are flawless. Welcome to contributors! 🎉
Please, if you'd like to help us with some other tasks I'd be thankful. Here are some I could use a fresh perspective on:
- Support nested where clauses #89 (nested
whereclauses support). - Feature Request/Unexpected behaviour: Graphql handlers just return string ids instead of relationships #99 (in progress in Supports relational types in GraphQL #110, generating GraphQL Schema pieces for relational properties).
- Or any other issue you find interesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue, when changes of regular properties are lost on update both properties and relations.