fix(Relation): support updating relation without initial value #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub
Root cause
The issue occurred because relation was applied only when parsing the model. So if it wasn't provided an initial value, the entire application was skipped:
data/src/model/defineRelationalProperties.ts
Lines 24 to 27 in cf67f57
This meant that when you update a parent entity, its relational property (
Relation
instance) didn't havesource
set at all, throwing an exception. This is not correct, even relational properties without initial values must be applied.Changes
target
/source
properties on theRelation
instance but does not define a proxy getter property.