fix(types): add generic type to MockedRequest.passthrough #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @sbaechler. Thanks for shipping this backport fix! I've tested it locally and all tests seem passing. I've tested this using our type tests at the time with TS versions 4.8 - 5.2, all type tests are passing as well. I think this should be good to go. |
kettanaito
approved these changes
Sep 7, 2024
Released: v1.3.4 🎉This has been released in v1.3.4! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using request.passthrough() in a handler that also returns data.
Closes #2195
I was not able to run the test suite without errors even in the
backport/v1branch. There were no type errors though.