feat(ws): support handleMessage
option on ws.link
#2236
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to accomplish a few things:
ws.link()
, not individual connections (i.e. consistency).Roadmap
ws.link
options.handleMessage
function.binaryType
(https://github.com/mswjs/socket.io-binding/blob/0db8a6193f06c2196cfd1880d07e153fa702e591/src/index.ts#L36)connection
, like.emit()
(https://github.com/mswjs/socket.io-binding/blob/0db8a6193f06c2196cfd1880d07e153fa702e591/src/index.ts#L81)socket.io
handles Blobs) (https://github.com/mswjs/socket.io-binding/blob/0db8a6193f06c2196cfd1880d07e153fa702e591/src/index.ts#L107)With this brief analysis, it looks like a single
handleMessage
option won't be enough to hook in a custom binding to your WebSocket connection. I may need to explore other means to provide a consistent, connection-wide API to augment the connection.