Master #1312
Master #1312
Conversation
Lightweight system for writing, administering, and running unit tests in C (mingw-w64)
Add HTTP/2 support through nghttp2 library and add metalink support through libmetalink.
library for handling paper characteristic
Fix libelf so that you have do not have unrecognized format errors.
| @@ -11,6 +11,7 @@ pkgname=("${MINGW_PACKAGE_PREFIX}-${_realname}" | |||
| "${MINGW_PACKAGE_PREFIX}-libc++abi" | |||
| patch -Np1 -i ${srcdir}/do-not-generate-import-library-for-executables.patch | ||
| patch -Np1 -i "${srcdir}/disable-response-files-for-msys.patch" | ||
| patch -Np1 -i "${srcdir}/dont-install-bundle.patch" | ||
| # patch -Np1 -i "${srcdir}/qt5-static-plugin-support.patch" |
There was a problem hiding this comment.
Why on earth have you disabled static plugin support?
There was a problem hiding this comment.
The problem is that the patch does not compile properly with the new version of CMake 3.5.1. I have not figured out how to fix that.
There was a problem hiding this comment.
But you can't just silently drop a patch in that instance, you break a whole lot of things. If that happens, then you forgo the update to cmake 3.5.1 instead. I spent weeks working on qt5-static and cmake-with-qt5-static, do you think it's reasonable to just break this without so much as a mention?
There was a problem hiding this comment.
Please remove the broken cmake 3.5.1 upgrade from this patchset. It represents a serious regression.
I'm sorry for being harsh here and really do appreciate the efforts, but please in future don't try to slip something like this into an otherwise good PR.
|
Please do not merge this Alexey, he's disabled static plugin support for Qt5 (qt5-static) which is a unique (and used) MSYS2 feature. |
|
@mingwandroid, yeah I forgot to mention it in comments. Thanks! |
Revert Back to 3.4.1 until qt5-static-plugin-support.patch can be fixed.
|
Thanks @JPeterMugaas, You can use |
Some new additions, and updates.