-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] rust: update to pre-release 1.69.0 #16847
Conversation
MINGW and UCRT fail with: this error
CLANG needs a patch adjustement. A fix is on its way. Note that the CLANG build with |
@mati865 any ideas why the MINGW build fails ? Could be related to : |
The issue is reminiscent of #10555 (comment) in the sense that PassBuilder.cpp.obj is involved again. Probably just a coincidence. |
Just noticed that it is EDIT: Nope, it is the CLANG build that uses |
I am pretty sure the issue is caused by the LLVM 16.0.0 upgrade that happened 3 weeks ago. The LLVM upgrade contains this change: llvm/llvm-project@95b27b2
Could making the template non const cause static linking to fail (i.e. the duplicate definitions cannot be merged because they are not const anymore)? |
Reverting the LLVM change fixes the build :) |
reverts this change: llvm/llvm-project@95b27b2 fixes the Rust build, see msys2#16847
Unfortunately i don't remember GCC template shenanigans but I guess it could be worth to give it a try. |
I opened an issue upstream : llvm/llvm-project#62270 |
reverts this change: llvm/llvm-project@95b27b2 fixes the Rust build, see msys2#16847
Switching to #16856 |
see https://blog.rust-lang.org/inside-rust/2023/04/17/1.69.0-prerelease.html