starship: update to 1.17.0

[ognevny]

patches are not needed now

[ognevny]

clangarm64 fails with

C:/Users/Administrator/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libz-ng-sys-1.1.12/src/zlib-ng/arch/arm/neon_intrins.h:5:12: fatal error: 'arm64_neon.h' file not found
        5 | #  include <arm64_neon.h>
          |            ^~~~~~~~~~~~~~
    1 warning and 1 error generated.
    make[2]: *** [CMakeFiles/zlib.dir/build.make:524: CMakeFiles/zlib.dir/arch/arm/compare256_neon.c.obj] Error 1
    make[2]: *** Waiting for unfinished jobs....
    warning: unknown warning option '-Wno-pedantic-ms-format'; did you mean '-Wno-pedantic-macros'? [-Wunknown-warning-option]
    1 warning generated.
    make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/zlib.dir/all] Error 2
    make: *** [Makefile:136: all] Error 2
    thread 'main' panicked at C:\Users\Administrator\.cargo\registry\src\index.crates.io-6f17d22bba15001f\cmake-0.1.50\src\lib.rs:1098:5:

[Biswa96]

This condition needs to be modified somehow https://github.com/zlib-ng/zlib-ng/blob/fd5b20f4ce5f0e8d4eafaad190dca5bc74a320fe/arch/arm/neon_intrins.h#L4

[ognevny]

This condition needs to be modified somehow

#if !defined(__MINGW32__)...?

edit: I think it's vendor by cargo vendor. I sadly has no test machine for it. I can try to fix it, but not very soon

[Biswa96]

Maybe || defined(__aarch64__)

[lazka]

(reverted for now)

[ognevny]

(reverted for now)

oh, maybe it would be better to just disable clangarm64... but ok

[lazka]

Also fine with me. Let's ask @naveen521kk who added the package in the first place.

[naveen521kk]

Let's ask @naveen521kk who added the package in the first place.

Fine with me :)

[ognevny]

in libz-ng-sys crate's repository I found this (maybe someone can help with it) and this (zlib-ng source is always vendored)

[mati865]

It should be fixed upstream by zlib-ng/zlib-ng@f9228d8
We can wait for a new release with rust-lang/libz-sys#162 or patch the vendored sources.

[ognevny]

It should be fixed upstream by zlib-ng/zlib-ng@f9228d8
We can wait for a new release with rust-lang/libz-sys#162 or patch the vendored sources.

ok. it's better to wait IMO

[ognevny]

opened a suggestion to bump crate's version
rust-lang/libz-sys#166