Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortran-stdlib: v0.6.0 #20874

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Fortran-stdlib: v0.6.0 #20874

merged 2 commits into from
Jun 2, 2024

Conversation

zoziha
Copy link
Contributor

@zoziha zoziha commented May 11, 2024

Description

Fortran-stdlib comes with modern Reference-BLAS built into v0.6.0, and also provides macro definitions to use external BLAS and LAPACK.
This PR upgrades Fortran-stdlib to v0.6.0 and links to OpenBLAS for optimized performance by adding a CMake patch.

@Biswa96
Copy link
Member

Biswa96 commented May 11, 2024

Did you try to upstream the patch?

@zoziha
Copy link
Contributor Author

zoziha commented May 12, 2024

Fortran-stdlib does not address enabling OpenBLAS or other implementations in CMake yet. Current focus is to implement linear algebra subroutines, that will come next.

Fortran-stdlib requires reasonable references to external BLAS libraries from complex sources (e.g. intel MKL, OpenBLAS, etc.), which requires a long implementation plan. Since the OpenBLAS package is included in MSYS2, my simple idea is to take advantage of it directly to get optimized performance, and I will continue to follow the progress of Fortran-stdlib.

@Biswa96, if you think it's not appropriate to add a CMake patch for Fortran-stdlib to MSYS2 at this stage, I'll remove the CMake linking OpenBLAS patch for Fortran-stdlib and revert to updating only the Fortran-stdlib version.

@Biswa96
Copy link
Member

Biswa96 commented May 12, 2024

In general, I prefer to upstream any significant changes first. I am not familiar with this project. Although I would welcome any change to improve performance. Please wait for other to comment on this PR.

@MehdiChinoune MehdiChinoune merged commit bba27ef into msys2:master Jun 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants