-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: enable Control Flow Guard on gnullvm #22325
base: master
Are you sure you want to change the base?
Conversation
for a future reference, why can't we enable it for other environments? it depends on support from local mingw-w64 runtime, right? |
I didn't test it, but I suppose the whole toolchain has to support it. |
Co-authored-by: Philippe Renon <[email protected]>
Just to clarify, does this enable it
and are there any differences to the official upstream builds? |
It's enabled for libstd (equivalent of libstdc++ from GCC), that is used by Rust and things built with Rust. The comment mentions only libstd, but I think it might be enabled for the compiler as well.
Not explicitly, it's similar to mingw-w64. Some checks will be pulled from the library, but to fully benefit from the feature (at a small performance penalty), it has to be enabled manually.
It allows enabling that option.
AFAICT upstream doesn't enable it in any provided builds. |
It works but not sure whether we should do it.