Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to node20 #332

Closed
MehdiChinoune opened this issue Oct 24, 2023 · 2 comments · Fixed by #333
Closed

update to node20 #332

MehdiChinoune opened this issue Oct 24, 2023 · 2 comments · Fixed by #333

Comments

@MehdiChinoune
Copy link
Contributor

node16 is deprecated by GHA
@lazka
Copy link
Member

lazka commented Oct 25, 2023

@jeremyd2019 as a self hosted runner user, do you have any insight whether there would by any downside if we just bump things to node20?

@jeremyd2019
Copy link
Member

should be fine, they don't let you keep old runner versions very long, and node20 has been included for a while now

lazka added a commit to lazka/setup-msys2 that referenced this issue Oct 26, 2023
@lazka
Use node20
4a4e456 
node16 is deprecated

Fixes msys2#332
@lazka lazka mentioned this issue Oct 26, 2023
Merged
lazka added a commit that referenced this issue Oct 26, 2023
@lazka
Use node20
2c1431d 
node16 is deprecated

Fixes #332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use node20 lazka/setup-msys2
3 participants
@lazka @jeremyd2019 @MehdiChinoune