forked from deepmodeling/deepmd-kit
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: bugs in uts for property fit (deepmodeling#4120)
This bug is totally the same as PR deepmodeling#3837. Fix following trivial bugs in property fit uts: - box was not used in extend_input_and_build_neighbor_list (which means they were all tested in nopbc mode, if shifted coord is outside the box (sometimes) and normalized explicitly, results are not the same.) Input for fitting also used extended_atype instead of atype. (Only same when nopbc.) - Using of mixed_types is disordered, mismatched with descriptor or sometimes with nlist. Now only use mixed_types==False since the descriptor output is not in mixed types. - Remove useless parameter `fit_diag` and `scale` test in property fitting. Add parameter `intensive` and `bias_method` test in property fitting. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced new parameters `intensive` and `bias_method` for enhanced flexibility in property fitting tests. - Added a new test class `TestInvarianceOutCell` with a method `test_trans` to evaluate invariance under transformations. - Updated existing tests to improve clarity and maintainability by removing the `scale` variable. - **Bug Fixes** - Refactored test methods to ensure correct parameter usage, enhancing the reliability of test outcomes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
- Loading branch information
1 parent
bda4824
commit fe7d2b5
Showing
1 changed file
with
171 additions
and
85 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters