Adding display driver types #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mteichtahl
commented
Nov 17, 2017
mteichtahl
commented
- Basic - no -ve support, no leading zero - Advanced - 0 left padded, leading zero support, -ve support
lurkerbot
reviewed
Nov 18, 2017
| type = "microdriver", | ||
| name="OH_FLT_DISPLAY", | ||
| driver = "microdriver", # these are the drivers from flightsim.eu | ||
| type = "advanced" # basic (like elec panel) , advanced (like ALT ALT) |
There was a problem hiding this comment.
could we give this flag a more specific value like "counted" vs "value"?
| if (value > 0) { | ||
| _matrixLED[displayNumber].group[groupIndex].value = convertedValue; | ||
| _pokey->MatrixLED[displayNumber].data[position] = convertedValue; | ||
| if (numberOfChars <= groupLength) { |
There was a problem hiding this comment.
this condition code is starting to get too long - refactor cases into methods
| @@ -29,6 +29,8 @@ | |||
| #define MAX_MATRIX_LED_GROUPS 8 | |||
| #define MAX_DIGITS 10 | |||
| #define MAX_PWM_CHANNELS 6 | |||
| #define DISPLAY_FORMAT_TYPE_BASIC "basic" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.