Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise asynchronous interface #105

Open
michaelgallaghertw opened this issue Sep 10, 2018 · 0 comments · May be fixed by #106
Open

Promise asynchronous interface #105

michaelgallaghertw opened this issue Sep 10, 2018 · 0 comments · May be fixed by #106

Comments

@michaelgallaghertw
Copy link

Both Jest and Mocha offer the same Promise-based asynchronous interface:

https://jestjs.io/docs/en/tutorial-async

// The assertion for a promise must be returned.
it('works with promises', () => {
  expect.assertions(1);
  return user.getUserName(4).then(data => expect(data).toEqual('Mark'));
});

Alternative syntax based on the same returned promise interface:
https://jestjs.io/docs/en/tutorial-async#resolves
https://jestjs.io/docs/en/tutorial-async#async-await

Currently storybook-addon-specifications accepts the done async interface, but not the Promise-based one.

I'll open a PR in a minute with this functionality implemented.

@mikeapr4 mikeapr4 linked a pull request Sep 10, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant