Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to resolve #105
For the moment the change only applies to
it
, though Jest/Mocha allows it on the before/after hooks too, so that might be some future work.The check for a returned Promise matches what Mocha does:
https://github.com/mochajs/mocha/blob/master/lib/runnable.js#L373
Nothing in this code actually requires the
Promise
class be available, means the code is compatible with pre-v0.12.18 node, although hardly a requirement to go back that far.I've updated some tests, though more for illustrative purposes, as those tests will not fail if async doesn't work. I've updated the docs too so users know they can use both the
done
and Promise interfaces.