Skip to content

Commit

Permalink
#128 Fix two minor typing failures (#205)
Browse files Browse the repository at this point in the history
Tweak typings

+ Make options in `forProtocol` optional
+ Add optional transport to `ClientOptions`
  • Loading branch information
Grisu118 authored and mtth committed Sep 27, 2018
1 parent 777811c commit 24017c6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ export class Service {
readonly types: Type[];

static compatible(client: Service.Client, server: Service.Server): boolean;
static forProtocol(protocol: any, options: any): Service;
static forProtocol(protocol: any, options?: any): Service;
static isService(obj: any): boolean;
}

Expand Down Expand Up @@ -231,6 +231,7 @@ export namespace Service {
strictTypes: boolean;
timeout: number;
remoteProtocols: boolean;
transport?: Transport;
}

interface ServerOptions {
Expand Down

0 comments on commit 24017c6

Please sign in to comment.