Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc 9.1 compatibility fixes #233

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Jikstra
Copy link

@Jikstra Jikstra commented Aug 20, 2019

This pr backports juce-framework/JUCE@4e0adb2 to make helm compile with gcc 9.1 again.
Fixes #232

@Jacalz
Copy link

Jacalz commented Sep 26, 2019

@mtytel Could you please merge this and make sure to tag a new release? The current release is totally broken on GCC 9.1 and later :(

@Jikstra
Copy link
Author

Jikstra commented Sep 26, 2019

@Jacalz as I don't have any merge rights on this repo I can't do a single thing. @mtytel has to help us with this.

@Jacalz
Copy link

Jacalz commented Sep 27, 2019

@Jacalz as I don't have any merge rights on this repo I can't do a single thing. @mtytel has to help us with this.

Yes I am well aware of that. That’s why I tagged @mtytel in the comment to indicate that it was aimed at him. On a further note, I have tested this and everything seems to work as expected 👍

@Jikstra
Copy link
Author

Jikstra commented Sep 27, 2019

Oh sorry, I somehow got confused...

@simonvanderveldt
Copy link

@mtytel Any chance this could be merged? Don't want to include patches in the package for it if it's not necessary.

@dvzrv
Copy link

dvzrv commented Mar 21, 2020

@mtytel Is there something keeping this patch from being merged?

Currently the package on Arch Linux is failing reproducible builds because of this.

@Skrylar
Copy link

Skrylar commented Jul 10, 2020

Thank you for fixing this 👍

teervo added a commit to teervo/helm-synth-fedora that referenced this pull request May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide proper build instructions
5 participants