Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/web assembly recorder #615

Merged
merged 3 commits into from
May 13, 2020
Merged

Fix/web assembly recorder #615

merged 3 commits into from
May 13, 2020

Conversation

jonklein
Copy link
Contributor

Several fixes & improvements for issues I found in using WebAssemblyRecorder:

  • fix audio feedback: set video element to muted

  • fix truncated video content: don't terminate the worker immediately, wait for the final message indicating that encoding is complete

  • fix video timescale not matching framerate: use setInterval instead of repeated setTimeouts to make sure frames are timed correctly instead of slipping

  • add a onVideoProcessStarted callback, which is useful for better synchronization of audio/video from different recorders

  • add realtime flag, defaulted to true (current behavior), to allow for non-realtime (higher quality) encoding. this is very slow, but may be useful.

@muaz-khan muaz-khan merged commit 7fe370f into muaz-khan:master May 13, 2020
@thijstriemstra
Copy link
Contributor

can you add a new release with this @muaz-khan?

@jonklein jonklein deleted the fix/web_assembly_recorder branch May 15, 2020 16:37
@thijstriemstra
Copy link
Contributor

thijstriemstra commented May 17, 2020

@jonklein did you test this with Firefox and polyfill, e.g. the online demo? https://www.webrtc-experiment.com/RecordRTC/simple-demos/WebAssemblyRecorder.html

18:14:32.051 TypeError: The stream is not in a state that permits enqueue
readable-stream.ts:1274:12
    enqueue readable-stream.ts:1274
    f RecordRTC.js:6008

It breaks the demo (and my project relying on recordrtc) so I have to revert back to recordrtc 5.5.9 for now unfortunately.

cc @muaz-khan

@thijstriemstra
Copy link
Contributor

screenshot:
Screenshot from 2020-05-17 18-16-51

@muaz-khan
Copy link
Owner

@thijstriemstra
Copy link
Contributor

thanks @muaz-khan looks good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants