Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes & improvements for issues I found in using WebAssemblyRecorder:
fix audio feedback: set video element to muted
fix truncated video content: don't terminate the worker immediately, wait for the final message indicating that encoding is complete
fix video timescale not matching framerate: use setInterval instead of repeated setTimeouts to make sure frames are timed correctly instead of slipping
add a
onVideoProcessStarted
callback, which is useful for better synchronization of audio/video from different recordersadd
realtime
flag, defaulted to true (current behavior), to allow for non-realtime (higher quality) encoding. this is very slow, but may be useful.