Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto select llama-cpp cuda runtime #2306
feat: auto select llama-cpp cuda runtime #2306
Changes from all commits
7df6910
ecd71b1
e9bca66
20b442a
c29825b
4bb8963
f0a688b
4ce686a
94d96c7
d917ec8
4e44e00
079ffeb
e7fc049
18bd7a8
578e34f
6586b09
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't
build
callgrpcs
target which calls make on all theGRPC_BACKENDS
including the llama-cpp variants?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct, I've split that off initially just for
STATIC=true
in order to build statically the (non-cuda) llama-cpp backends.I've added the cuda switch here and not at the top because we don't need container images or the generic
build
target to include a specific backend for cuda - container images are already built with the BUILD_TYPE which compiles all thellama-cpp
variants against the accellerator library for the specific container images (sycl, hipblas, cuda, etc).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why fallback here?
LLamaCPP
should fallback automatically if runtime is not avx2 or avxThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, but what if they fail when being started? What I was trying to do here is recovering from failures outside our control, but more related to the environment where this starts e.g. missing shared libraries goes undetected until the grpc process is started.
Example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, makes sense. Current GPU detection is pretty naive so that should definitely be improved by checking for the cuda libs.