Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve timesyncd plugin #182

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Improve timesyncd plugin #182

merged 1 commit into from
Oct 18, 2024

Conversation

Itxaka
Copy link
Collaborator

@Itxaka Itxaka commented Oct 18, 2024

  • Set empty value if the value as strings if value is empty instead of omitting the value
  • Write config to /etc/systemd/timesyncd.conf.d/10-yip.conf to properly override the existing config and any others shipped with the system

@Itxaka
Improve timesyncd plugin
34ab28c 
 - Set empty value if the value as strings if value is empty instead of
   omitting the value
 - Write config to /etc/systemd/timesyncd.conf.d/10-yip.conf to properly
   override the existing config and any others shipped with the system

Signed-off-by: Itxaka <[email protected]>
@Itxaka Itxaka linked an issue Oct 18, 2024 that may be closed by this pull request
Timesyncd empty FallbackNTP does not clear the list #181
Closed
@mudler mudler merged commit f16f016 into master Oct 18, 2024
3 checks passed
Itxaka
Itxaka commented Oct 19, 2024
View reviewed changes
pkg/plugins/timesyncd.go
@@ -33,7 +40,11 @@ func Timesyncd(l logger.Interface, s schema.Stage, fs vfs.FS, console Console) e
}

for k, v := range s.TimeSyncd {
cfg.Section("Time").Key(k).SetValue(v)
if v == "" {
cfg.Section("Time").Key(k).SetValue("\"\"")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is kind of wrong :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudler mudler mudler approved these changes

@mauromorales mauromorales Awaiting requested review from mauromorales

@jimmykarily jimmykarily Awaiting requested review from jimmykarily

@davidcassany davidcassany Awaiting requested review from davidcassany

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timesyncd empty FallbackNTP does not clear the list
2 participants
@Itxaka @mudler