Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(output): use withcolorcache on the default output #130

Closed
wants to merge 2 commits into from

Conversation

aymanbagabas
Copy link
Collaborator

@aymanbagabas aymanbagabas commented Apr 6, 2023

This should reduce how many times an application query the terminal for the background.

This also fixes querying the terminal when the WithColorCache option is invoked. We don't need to cache the fg/bg colors when we instantiate a termenv.Output, instead, lazy cache the colors whenever they're requested.

@aymanbagabas aymanbagabas requested a review from muesli April 6, 2023 21:40
We don't need to cache the fg/bg colors when we instantiate a
termenv.Output, instead, lazy cache the colors whenever they're
requested.
@aymanbagabas
Copy link
Collaborator Author

Superseded by #132 & #149

@aymanbagabas aymanbagabas deleted the default-color-cache branch August 26, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant