Do not support literal HTML in the Administration Interface #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the difference is that you "wash" the output only for the admin interface. Makes sense to me. |
|
+1 on this. Especially since I have previously managed to break the admin interface with a literal HTML snippet myself without realizing straight away. |
|
Upstream pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many sites support literal HTML for front-end sites. However, we have found this to be nothing but damaging for the Administration Interface, whether that's JavaScript breaking the functionality or CSS breaking the layout. The simple fix is to disable support for the "html" literal tag class in the Administration Interface.