Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination of embedded media search on admin fixed #148

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

pkamps
Copy link
Member

@pkamps pkamps commented May 20, 2019

Background
Media content search results through embedded browse on admin site looses "media" context upon pagination and returns much larger search result. That's coming from the CSM project and is a bug in the legacy kernel.

Testing instructions

  • In the media lib, do a search that returns more that one page of result sets (you may need to create some dummy content for that)
  • On that result set, click on page 2
  • Confirm you are still showing result sets in context of only the media lib
    (Without this pull request, you would be in the context of the 'Content Structure' and it would potentially return more result entries)

@pkamps pkamps self-assigned this May 20, 2019
@peterkeung
Copy link
Member

Based on the description, an upstream PR should be made as well

@pkamps
Copy link
Member Author

pkamps commented May 24, 2019

Upstream pull request: ezsystems#1433

@pkamps pkamps removed their assignment May 24, 2019
@pkamps
Copy link
Member Author

pkamps commented Jun 4, 2019

Ready to get merged.

@pkamps pkamps merged commit da8baf2 into master Jun 5, 2019
@pkamps pkamps deleted the search_context_fix branch June 5, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants