Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set custom tags as "hidden" #153

Merged
merged 3 commits into from
Jun 5, 2019
Merged

Allow to set custom tags as "hidden" #153

merged 3 commits into from
Jun 5, 2019

Conversation

pkamps
Copy link
Member

@pkamps pkamps commented May 24, 2019

Background
You want to be able to hide ezoe custom tags in the UI - so that editor cannot use that custom tag anymore. But you don't want to completely remove the custom tag because your content already is using that custom tag. The solution is to allow to hide specific custom tags. Something like making them "deprecated".

Solution
In the settings you can specify which custom tag is hidden and it won't show in the editor UI anymore.

Testing instructions

  • Change the settings and mark a custom tag as "hidden"
  • Go to the admin UI and confirm that this custom tag is not available anymore in the dropdown box

@peterkeung
Copy link
Member

We needed this on AMNH as well, and implemented a solution fully in templates. This is cleaner, so +1 in general. However, the INI documentation should be improved so that it's clear that you put the identifier as the key and "true" (or "false") as the value. Then this so go to upstream as well.

@pkamps
Copy link
Member Author

pkamps commented May 28, 2019

Thanks for pointing that out. I don't like how you had to specify the setting (very uncommon). So I decided to simplify the settings. I also added an example in the settings file.

@pkamps
Copy link
Member Author

pkamps commented Jun 4, 2019

Ready to get merged.

@pkamps pkamps merged commit e21ef46 into master Jun 5, 2019
@pkamps pkamps deleted the hide_custom_tag branch June 5, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants