-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding function "createNew" to simplify the creation of a ezsitedata entry #33
Conversation
|
Ha, it's so good to have people reviewing your code.
|
|
Point 1) and 3) addressed. |
I have tested this, it works great and it is very flexible. This seems to be a good replacement for objects created in the CMS with a focus on storing data that is not going to be directly edited by the users. Creating a value and creating a new value with the same key(name) will overwrite any existing value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 other than these doc fixes
@@ -8,38 +8,64 @@ | |||
* @package kernel | |||
*/ | |||
|
|||
/** | |||
* eZPersistentObject implementation for ezsite_data table. | |||
* Allows to store and fetch key/value pairs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Allows" should be "Enables you"
); | ||
} | ||
|
||
/** | ||
* Cronstructs a new eZSiteData instance. You need to call 'store()' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Constructs" not "Cronstructs"
Typos fixed. Please confirm. |
Good to squash and merge. |
ezp pull request: |
Most changes are due to code reformatting. I added a new function "createNew" to simplify the creation process.
The function has a new unit test.