Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object info has a new section "Published version" containing all details if it exists #56

Merged
merged 2 commits into from
May 17, 2017

Conversation

pkamps
Copy link
Member

@pkamps pkamps commented May 9, 2017

This pull requests affects the "object_information.tpl" template. It is shown if you edit a content object of if you look at the version history for a content object.

http://devmanage.lovestack.mugo.ca/content/history/58
http://devmanage.lovestack.mugo.ca/content/edit/58

The top section "Object information" contains the details:
ID (object ID)
Created (creation time + creator user name)
Modified (object modification + user name of that last modification)
Published version (version id number)

The Modified details are buggy currently - see:
ezsystems#1296

The pull request 1296 fixes the issue - but I think it's worth considering to also re-organize the object information a little. This pull request fixes the buggy Modified details and additionally puts the details from Modified and Published version into a dedicated section called 'Published version'.

See the 2 screenshots:

NEW:
screen shot 2017-05-09 at 15 12 16

OLD:
screen shot 2017-05-09 at 15 12 08

@peterkeung
Copy link
Member

I don't mind the reorganization, but did you purposely rename Modified to Created under "Published version"? Regardless of the other fix, it's technically inaccurate with that change of wording, because you are outputting the modified date.

That also brings up the question about whether an editor cares more about seeing the created or modified dates for the published version. They're usually quite close, and I don't have a strong opinion about changing it from modified to created.

@benkmugo
Copy link
Member

I'd show both created and modified information for the published version. Plenty of space in the sidebar.

@pkamps
Copy link
Member Author

pkamps commented May 11, 2017

I don't like the idea of listing the both the creation, modification date. It's a technical detail most editors are not interested in, I think. The version list has those 2 timestamps and it's probably the right view to show these details.

I think an editor just wants to know when the current public version was published - technically that's the modification timestamp of the published version. So I think I should call it 'Modified:'. Or maybe should I call it 'Published:'?

I do 2 more re-organisations:

  1. Swap version owner name with timestamp to make it consistent for both groups
  2. Swap the 'ID:' with the 'Created:' field under 'Object Information'

@pkamps
Copy link
Member Author

pkamps commented May 15, 2017

New version I suggest:
screen shot 2017-05-15 at 09 49 44

@peterkeung
Copy link
Member

I am +1 with the wording change to "Published" while still using the "modified" property.

@benkmugo
Copy link
Member

+1 on that

@pkamps pkamps merged commit 3adc41a into master May 17, 2017
@pkamps pkamps deleted the improved_object_info branch May 25, 2017 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants