Make Template Operators utf8 friendly #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to the idea, but it should be run through the enterprise support channel to get eZ QA |
|
+1 on the patch as well as Peter's suggestion. I wonder why they never merged Graham's PR back then, the thing is 2 years old now. |
|
@pkamps This looks good. Would you like to open a PR against our repo, or should we? |
|
@glye please see related pull request in upstream |
|
Thanks! |
|
Merged by eZ, so merging here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run into this problem in context of the CSM project. Try this in your template
It will break the string because the PHP function
substrcannot handle utf8 string (see the funny i at the end of fipsï).I found that hidden gem from Graham: ezsystems#1162
So I basically did the same thing but did not use the dynamic $funcName idea. The mbstring PHP extension is listed as a requirement for ezp and I think that's good because you want to be able to handle utf8 strings on your website.