user only can follow others, not himself

muhammadmp97 · Sep 18, 2023 · 0d685a8 · 0d685a8
1 parent 8c541e5
commit 0d685a8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/app/Actions/User/FollowUserAction.php b/app/Actions/User/FollowUserAction.php
@@ -4,11 +4,16 @@
 
 use App\Models\User;
 use App\Notifications\NewFollowerNotification;
+use Symfony\Component\HttpKernel\Exception\HttpException;
 
 class FollowUserAction
 {
     public function execute(User $follower, User $following): void
     {
+        if ($follower->is($following)) {
+            throw new HttpException(400, 'No one follows himself!');
+        }
+
         $userIsFollowed = $follower
             ->following()
             ->where('following_id', $following->id)

diff --git a/tests/Feature/UserFollowersControllerTest.php b/tests/Feature/UserFollowersControllerTest.php
@@ -87,4 +87,11 @@ public function test_user_unfollows_following_user()
 
         $this->assertDatabaseEmpty('followers');
     }
+
+    public function test_user_cannot_follow_himself()
+    {
+        $this
+            ->postJson('api/users/1/followers')
+            ->assertStatus(400);
+    }
 }