refactoring by extracting the passedDays() method

muhammadmp97 · Sep 17, 2023 · 42c7255 · 42c7255
1 parent 3139248
commit 42c7255
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/app/Listeners/ChallengeAchievementsListener.php b/app/Listeners/ChallengeAchievementsListener.php
@@ -15,13 +15,7 @@ public function __construct(
 
     public function handle($event)
     {
-        $passedDays = $event
-            ->challenge
-            ->continued_at
-            ->diff($event->challenge->created_at)
-            ->d;
-
-        $achievement = Achievement::getByPassedDays($passedDays);
+        $achievement = Achievement::getByPassedDays($event->challenge->passedDays());
 
         if (! $achievement) {
             return;

diff --git a/app/Models/Challenge.php b/app/Models/Challenge.php
@@ -34,6 +34,14 @@ public function isLikedBy($userId): bool
             ->exists();
     }
 
+    public function passedDays(): int
+    {
+        return $this
+            ->continued_at
+            ->diff($this->created_at)
+            ->d;
+    }
+
     public function user()
     {
         return $this->belongsTo(User::class);