Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: following recommendation #8

Merged
merged 4 commits into from
Sep 23, 2023
Merged

feat: following recommendation #8

merged 4 commits into from
Sep 23, 2023

Conversation

hamoda-dev
Copy link
Contributor

@hamoda-dev hamoda-dev commented Sep 22, 2023 •
edited
Loading

How it works

the recommended user is from the same country and same addiction type

muhammadmp97
muhammadmp97 reviewed Sep 22, 2023
View reviewed changes
Copy link
Owner

@muhammadmp97 muhammadmp97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I injected the FollowingRecommendation service using method injection.
  2. No need to the UserRecommendationResource class.
  3. Foreign keys are indexed by default.
  4. A small change in endpoints to follow crud-stlye rules.
  5. A typo fixed.
  6. Test class refactored.

muhammadmp97
muhammadmp97 reviewed Sep 23, 2023
View reviewed changes
Copy link
Owner

@muhammadmp97 muhammadmp97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good for now, but of course we can improve it to be more efficient and sensible.

@muhammadmp97 muhammadmp97 merged commit ace8070 into muhammadmp97:master Sep 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhammadmp97 muhammadmp97 muhammadmp97 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamoda-dev @muhammadmp97