Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Run tests with vitest #749

Merged
merged 17 commits into from
Oct 29, 2024
Merged

[test] Run tests with vitest #749

merged 17 commits into from
Oct 29, 2024

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Oct 21, 2024

Sets up the infrastructure for Vitest (including the code from mui/material-ui#43625) and configures the CI to run tests using it.

@michaldudak michaldudak requested a review from a team October 21, 2024 11:04
@mui-bot
Copy link

mui-bot commented Oct 21, 2024

Netlify deploy preview

https://deploy-preview-749--base-ui.netlify.app/

Generated by 🚫 dangerJS against cf5a103

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 23, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 28, 2024
@michaldudak michaldudak marked this pull request as ready for review October 29, 2024 12:12
Comment on lines +69 to +72
// @ts-expect-error to support mocha and vitest
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
this?.skip?.() || t?.skip();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No way to make this cleaner?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet. We'll get rid of this once we drop mocha completely (= soon, I hope)

@michaldudak michaldudak merged commit dd67366 into mui:master Oct 29, 2024
18 checks passed
@michaldudak michaldudak deleted the vitest branch October 29, 2024 13:38
atomiks pushed a commit to atomiks/base-ui that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants