Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [email protected] support with createSvgIcon #1629

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Conversation

Vincz
Copy link
Contributor

@Vincz Vincz commented Apr 8, 2020

Update import of createSvgIcon according to closes #1619.

@vercel
Copy link

vercel bot commented Apr 8, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/mui-org/material-ui-pickers/eipm1aa2t
✅ Preview: https://material-ui-pickers-git-fork-vincz-next.mui-org.now.sh

@dmtrKovalenko
Copy link
Member

Missed global module name in rollup config. But everything else looks good

@Vincz
Copy link
Contributor Author

Vincz commented Apr 8, 2020

Thx for the quick review @dmtrKovalenko !

I'm not sure about this two files:
material-ui-pickers/lib/rollup.config.js

and

material-ui-pickers/lib/typings.d.ts

Can you help me?
Thanks!

@dmtrKovalenko
Copy link
Member

In typings — remove our overrides.
In rollup config — add to globals:

‘{new import path}’: materialUi.utils

@oliviertassinari oliviertassinari changed the title Update createSvgIcon import following @material-ui v4.9.9 update Fix [email protected] support with createSvgIcon Apr 8, 2020
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #1629 into next will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1629   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files          64       64           
  Lines        1797     1797           
  Branches      324      307   -17     
=======================================
  Hits         1655     1655           
  Misses        108      108           
  Partials       34       34           
Impacted Files Coverage Δ
lib/src/_shared/icons/ArrowDropDownIcon.tsx 100.00% <100.00%> (ø)
lib/src/_shared/icons/ArrowLeftIcon.tsx 100.00% <100.00%> (ø)
lib/src/_shared/icons/ArrowRightIcon.tsx 100.00% <100.00%> (ø)
lib/src/_shared/icons/ClockIcon.tsx 100.00% <100.00%> (ø)
lib/src/_shared/icons/DateRangeIcon.tsx 100.00% <100.00%> (ø)
lib/src/_shared/icons/KeyboardIcon.tsx 100.00% <100.00%> (ø)
lib/src/_shared/icons/PenIcon.tsx 100.00% <100.00%> (ø)
lib/src/_shared/icons/TimeIcon.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eca4db...0d01f13. Read the comment docs.

@dmtrKovalenko dmtrKovalenko merged commit c38b5ed into mui:next Apr 9, 2020
@Vincz
Copy link
Contributor Author

Vincz commented Apr 9, 2020

Awesome ! Thx @oliviertassinari & @dmtrKovalenko !
Is it possible to publish the updated version on npm ?
Thanks!

@dmtrKovalenko
Copy link
Member

Yeah, will publish it asap. Probably tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createSvgIcon refactor in @material-ui 4.9.9 breaking builds
3 participants