Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix minDate error message in Formik example #1746

Merged
merged 1 commit into from
May 6, 2020
Merged

[docs] Fix minDate error message in Formik example #1746

merged 1 commit into from
May 6, 2020

Conversation

jozsi
Copy link
Contributor

@jozsi jozsi commented May 6, 2020

The error handling introduced in v4.0.0-alpha6 is amazing! There's just a tiny issue in the Formik example: the minDate message is the same as the maxDate one. This PR addresses it.

@vercel
Copy link

vercel bot commented May 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/ks5goz4gm
✅ Preview: https://material-ui-pickers-git-fork-jozsi-patch-1.mui-org.now.sh

Copy link
Member

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are so quick! Thanks

@dmtrKovalenko dmtrKovalenko merged commit d98efe8 into mui:next May 6, 2020
@dmtrKovalenko
Copy link
Member

Thanks, your fixed was already deployed to https://next.material-ui-pickers.dev/guides/forms

@jozsi jozsi deleted the patch-1 branch May 6, 2020 16:32
@oliviertassinari oliviertassinari changed the title Fix minDate error message in Formik example [docs] Fix minDate error message in Formik example May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants