Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/date range crash when invalid date #1755

Merged
merged 7 commits into from
May 7, 2020

Conversation

dmtrKovalenko
Copy link
Member

This PR closes #1748

Description

Fix issues caused by DateRangePicker and new validation strategy

@vercel
Copy link

vercel bot commented May 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/5x7njnl9a
✅ Preview: https://material-ui-picker-git-bugfix-daterange-crash-when-inval-63e10f.mui-org.now.sh

@cypress
Copy link

cypress bot commented May 7, 2020



Test summary

77 0 1 0


Run details

Project material-ui-pickers
Status Passed
Commit 8d51f0a
Started May 7, 2020 3:23 PM
Ended May 7, 2020 3:25 PM
Duration 01:32 💡
OS Linux Debian - 9.11
Browser Chrome 78

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #1755 into next will increase coverage by 0.36%.
The diff coverage is 80.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1755      +/-   ##
==========================================
+ Coverage   90.34%   90.70%   +0.36%     
==========================================
  Files          77       77              
  Lines        2319     2324       +5     
  Branches      435      439       +4     
==========================================
+ Hits         2095     2108      +13     
+ Misses        181      174       -7     
+ Partials       43       42       -1     
Impacted Files Coverage Δ
lib/src/_shared/PureDateInput.tsx 100.00% <ø> (ø)
lib/src/_shared/hooks/useMaskedInput.tsx 96.07% <ø> (+1.96%) ⬆️
lib/src/_shared/hooks/usePickerState.ts 88.46% <ø> (ø)
lib/src/views/Calendar/Calendar.tsx 85.24% <ø> (+0.96%) ⬆️
.../src/DateRangePicker/DateRangePickerViewMobile.tsx 33.33% <33.33%> (-3.04%) ⬇️
lib/src/views/Calendar/CalendarView.tsx 93.65% <60.00%> (-2.91%) ⬇️
lib/src/DateRangePicker/DateRangePickerInput.tsx 87.87% <100.00%> (+9.41%) ⬆️
...src/DateRangePicker/DateRangePickerViewDesktop.tsx 80.95% <100.00%> (+0.95%) ⬆️
lib/src/_helpers/date-utils.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d98efe8...8d51f0a. Read the comment docs.

@dmtrKovalenko dmtrKovalenko merged commit efd9556 into next May 7, 2020
@dmtrKovalenko dmtrKovalenko deleted the bugfix/DateRange-crash-when-invalid-date branch May 7, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateRangePicker: crashes when opening view with an invalid date
1 participant