[DateTimePicker] Always show arrow switcher in clock #1949
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/h4t548a5u |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| import TextField from '@material-ui/core/TextField'; | ||
| import isWithinInterval from 'date-fns/isWithinInterval'; |
There was a problem hiding this comment.
A couple of thoughts:
- The diff isn't related to the problem we are trying to solve. It makes the review a bit harder.
- I think that we should welcome the initiative to leave the space in better shape when we first come in. Thanks for that.
- Why do we have rules as a warning? Outside of the transitioning period, I think that it should either be an error or off.
- What do you want to do with the
pretty-imports/sortedrule? Do you want to keep it? If so, please make the case for it on https://github.com/mui-org/material-ui.
There was a problem hiding this comment.
This rule is more like my own preference. I will not open an RFC for the usage of this rule :)
looks like more developers tend to not sort imports at all.
The main idea of this rule is to be used with autoFix, honestly it should be a plugin for prettier and not an eslint rule.
There was a problem hiding this comment.
There is a less strict import sorting rule right now, it's about using relative imports (./) after global ones. Having to run eslint autofix could be an issue. I think that we gave up on it on the main repository because it was too slow to run. I don't know if there are alternatives.
This PR closes #1925