Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix guides links to point to next #2048

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

aamirafridi
Copy link
Contributor

@aamirafridi aamirafridi commented Jul 29, 2020

PR to fix this bug

@vercel
Copy link

vercel bot commented Jul 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/bsto7xsfx
✅ Preview: https://material-ui-pickers-git-fork-aamirafridi-fix-docs-link.mui-org.vercel.app

@cypress
Copy link

cypress bot commented Jul 29, 2020



Test summary

78 0 3 0


Run details

Project material-ui-pickers
Status Passed
Commit e862318
Started Jul 29, 2020 4:28 PM
Ended Jul 29, 2020 4:30 PM
Duration 01:43 💡
OS Linux Debian - 10.0
Browser Chrome 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@dmtrKovalenko dmtrKovalenko merged commit df3010b into mui:next Jul 29, 2020
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the other cases where the URL is wrong? For instance:

https://github.com/mui-org/material-ui-pickers/blob/df3010bee046034178b5859ce4fd81755cb1d5e4/lib/src/views/Calendar/Calendar.tsx#L24

Also, to be noted that in the main repository, we remove the URL prefix to have the link work no matter the URL it's live on. This comes with one tradeoff, it doesn't work inside IntelliSense.

I think that we should remove the prefixes to prepare the migration in the main repo.

@oliviertassinari oliviertassinari changed the title updated guides links to point to next [docd] Fix guides links to point to next Jul 29, 2020
@oliviertassinari oliviertassinari changed the title [docd] Fix guides links to point to next [docs] Fix guides links to point to next Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link in the docs
3 participants