Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IconButton] IconButton sizes are no longer fixed and vary #12988

Closed
2 tasks done
jlascoleassi opened this issue Sep 24, 2018 · 2 comments
Closed
2 tasks done

[IconButton] IconButton sizes are no longer fixed and vary #12988

jlascoleassi opened this issue Sep 24, 2018 · 2 comments
Labels
status: waiting for author Issue with insufficient information

Comments

@jlascoleassi
Copy link
Contributor

As of v3.1.x, the IconButton size was removed and the padding was changed, due to this commit:

fc42dde#diff-fde406414bd717fcea45f653b5632078

The icon buttons now vary in size and when they are next to each other especially, it's very odd and jarring. Was there a reason the width / height of 48 was removed and the padding went from 0 to 12? We use the FontAwesome library for our icons but that should not (and doesn't appear to) have an impact.

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

The buttons should be sized consistently

Current Behavior

They vary in size

Steps to Reproduce

Link:

Context

Your Environment

Tech Version
Material-UI v3.1.x
React
Browser
TypeScript
etc.
@eps1lon
Copy link
Member

eps1lon commented Sep 24, 2018

Could you add a repro so that a possible fix can test against that?

@oliviertassinari oliviertassinari added the status: waiting for author Issue with insufficient information label Sep 24, 2018
@oliviertassinari
Copy link
Member

Your issue has been closed because it does not conform to our issue requirements.
Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

3 participants