Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField styling has changed #12994

Closed
2 tasks done
jozsi opened this issue Sep 24, 2018 · 10 comments
Closed
2 tasks done

TextField styling has changed #12994

jozsi opened this issue Sep 24, 2018 · 10 comments
Assignees
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module!

Comments

@jozsi
Copy link
Contributor

jozsi commented Sep 24, 2018

The TextField is acting differently in v3.1.1 compared to prior versions. Look at the downshift > Select multiple countries example:

screen shot 2018-09-24 at 23 55 52

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

I would expect the TextField to be to the right of the chips and we wrapped only if it doesn't fit to the right anymore.

Current Behavior

The TextField is wrapped on a second line after a first selection.

Steps to Reproduce

Link: https://material-ui.com/demos/autocomplete/

  1. Go to the downshift example
  2. Select a country in the second input field

Context

Visually broke the multi-select component.

Your Environment

Tech Version
Material-UI v3.1.1
Chrome v69
@hburrows

This comment has been minimized.

@mbrookes mbrookes added bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! labels Sep 24, 2018
@oliviertassinari

This comment has been minimized.

@eps1lon
Copy link
Member

eps1lon commented Sep 25, 2018

What @hburrows describes might be related to #12988.

@hashwin
Copy link
Contributor

hashwin commented Sep 25, 2018

In previous versions - or at least up through v3.0.1 - the alignment is fine. I'm also using Chrome v69.

It was fine in 3.1.0, but broken in 3.1.1

keep_pipelines_as_trials_that_expire_unless_payment_begins

@katzoo
Copy link
Contributor

katzoo commented Sep 25, 2018

3.1.1 also affects styling of outlined fields (with and without labels).
password

textfield

https://material-ui.com/demos/text-fields/#outlined

@eps1lon
Copy link
Member

eps1lon commented Sep 25, 2018

#12975 broke the downshift select example. Without width: 100% the example lookes like 3.1.0.

@AirborneEagle
Copy link

I am also running into the strike-through problem that @katzoo described on 3.1.1
screenshot:
image

@hburrows
Copy link
Contributor

I retract my issue. It turned out I had some legacy CSS that was causing my issue -- likely due to CSS changes related to this. Removing my CSS altogether fixed my issue.

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 29, 2018

@katzoo What environment are you using to see this?

password

I have noticed it too on my Oneplus 6 on Chrome 69, but it's an indeterministic rendering artifact. We would have to fall back to the SVG implementation of @enagy27 to completely remove it. At the cost of a higher bundle size?

@katzoo
Copy link
Contributor

katzoo commented Oct 1, 2018

@oliviertassinari I can only see this only in Chrome (stable 69.0.3497.100 as well as dev 71.0.3565.0), but maybe it's somehow related to how Chrome handles OS upscaling (125% for 4k resolution) - especially when changing page zoom (in browser) once makes this glitch disappear (I've seen worse regressions in "stable" versions :) ). Couldn't reproduce this in Firefox or any other machine with Chrome stable, so it seems like non material-ui issue.

The other thing went away with 3.1.2, so thank you and @slipo for fixing this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

8 participants