-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Drop the component
prop from all Base UI components
#36679
Comments
Not sure if it's relevant to this issue - I've opened a PR while back which fixes typescript issues when using I'm just wondering relevance of the PR as |
I am working on the PR: #37041 |
edit: TextareaAutosize doesn't have |
I am working on the PR: #37060 |
thanks.. I will update the descriptions |
i'll pick up |
@sai6855 @nicolas-ot |
@sai6855 Reviewed them. All looks ready :) |
|
@nicolas-ot @sai6855 We got the job done! The changes will be included in today's release. Appreciate a lot for your amazing contributions.. :) |
Summary 💡
Currently, there are two different APIs for setting the root slot in Base UI (using the
component
prop and using theslots.root
prop).The difference between these two APIs is that the component prop makes the component polymorphic, which means that you can propagate the root component's props on the unstyled component directly, without getting typescript issues. However, this has shown to have big performance implications when doing the type checks (see some existing issues for the Material UI's components).
Progress 🚧
This is the list of components that should be changed with this proposal:
component
prop #37028component
prop #36677The text was updated successfully, but these errors were encountered: