Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TabPanel] drop component prop #37054

Merged
merged 5 commits into from
Apr 28, 2023
Merged

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Apr 27, 2023

part of #36679

TabPanel didn't have dedicated documentation page, so i couldn't update docs like i did here (https://deploy-preview-36770--material-ui.netlify.app/base/react-tabs/#usage-with-typescript)

BREAKING CHANGE

It will be covered by codemod, see #36831

For Base UI components, the component prop value should be moved to slots.root:

 <TabPanel
-  component="span"
+  slots={{ root: "span" }}
 />

If using TypeScript, you should add the custom component type as a generic on the TabPanel component.

-<TabPanel
+<TabPanel<typeof CustomComponent>
   slots={{ root: CustomComponent }}
   customProp="foo"
 />

@sai6855 sai6855 added breaking change package: base-ui Specific to @mui/base labels Apr 27, 2023
@mui-bot
Copy link

mui-bot commented Apr 27, 2023

Netlify deploy preview

https://deploy-preview-37054--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 2778fea

@hbjORbj hbjORbj merged commit 988e0ad into mui:master Apr 28, 2023
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants