Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Component: Search Field #1446

Closed
wants to merge 19 commits into from
Closed

New Component: Search Field #1446

wants to merge 19 commits into from

Conversation

yongxu
Copy link
Contributor

@yongxu yongxu commented Aug 18, 2015

New Component Search Field
f56082d0-c6aa-4477-ae37-02dfe5e78582

renxx91 and others added 19 commits August 14, 2015 21:05
@oliviertassinari
Copy link
Member

@yongxu That's an interesting start! It could potentially resolve #579 and #18. I think that we should call this component Typeahead. @shaurya947
Can you also rebase and squash down the number of commit? Thanks 👍

oliviertassinari
oliviertassinari reviewed Oct 23, 2015
View reviewed changes
src/search-field.jsx
<div style={mergedRootStyles}
onKeyDown={(e)=>{
switch(e.keyCode){
case 27: //esc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use https://github.com/callemall/material-ui/blob/master/src/utils/key-code.js

@yongxu
Copy link
Contributor Author

yongxu commented Oct 24, 2015

Thanks for the review @oliviertassinari !
This is a component I posted a while ago, before react 0.14 came out.
I am going to make some changes, make sure everything works, rebase it just making sure everything works tonight.

@yongxu yongxu mentioned this pull request Oct 25, 2015
Closed
@yongxu
Copy link
Contributor Author

yongxu commented Oct 25, 2015

Another working pull request #1985 will replace this one.
Please check that one out!

@yongxu yongxu closed this Oct 25, 2015
@snyk-bot snyk-bot mentioned this pull request Jun 26, 2021
Open
@zannager zannager added component: text field This is the name of the generic UI component, not the React module! component: autocomplete This is the name of the generic UI component, not the React module! labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yongxu @oliviertassinari @zannager @renxx91