Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tab] Enable generic props #15003

Merged
merged 6 commits into from
Mar 23, 2019
Merged

[Tab] Enable generic props #15003

merged 6 commits into from
Mar 23, 2019

Conversation

caroe233
Copy link
Contributor

Changed the Tab component to work with generic props (see mui-org#13868)

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 22, 2019 •
edited
Loading

No bundle size changes comparing f9896bc...4595de7

Generated by 🚫 dangerJS against 4595de7

@oliviertassinari oliviertassinari added component: tabs This is the name of the generic UI component, not the React module! typescript labels Mar 22, 2019
@eps1lon eps1lon merged commit 7ee2a08 into mui:next Mar 23, 2019
@eps1lon eps1lon changed the title [Tab] Enable generic props for Tab component [Tab] Enable generic props Mar 23, 2019
@eps1lon
Copy link
Member

eps1lon commented Mar 23, 2019

@caroe233 Very nice, thanks!

@eps1lon eps1lon mentioned this pull request Mar 25, 2019
Merged
1 task
@joshwooding joshwooding mentioned this pull request Mar 31, 2019
Merged
1 task
@eps1lon eps1lon mentioned this pull request Mar 31, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
component: tabs This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caroe233 @mui-pr-bot @eps1lon @oliviertassinari