[docs] Add some Card TypeScript demos #15011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
reviewed
Mar 22, 2019
oliviertassinari
added
docs
|
The import order between JS and TS should be equal. I know it's just visual but we need the demos to be equivalent. Otherwise we won't catch future regressions automatically. |
|
Yeah, makes sense. I changed the order back, so they match the ones from the JS files. Shouldn't thave used the VS Code organize import tool to remove ununsed imports 😅 |
|
No bundle size changes comparing f9896bc...d9ef87f |
eps1lon
approved these changes
Mar 22, 2019
Closed
eps1lon
changed the title
|
@Dudrie Much appreciated, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added demos in for the Card section of the documentation. However,
ImgMediaCardis not included because there are typing issues with the CardMedia (see #15010).