Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add undesired withStyles + generic props component behavior #15215

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 5, 2019

Minimal test for undesired behavior reported in #14586

Will need to investigate a solution without unions. Especially considering typescript 3.4.1 has a 20x perf regression with distributive unions.

Any other ideas @pelotom ?

@eps1lon eps1lon added test package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. labels Apr 5, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing 496b0ff...f57812b

Generated by 🚫 dangerJS against f57812b

@eps1lon eps1lon merged commit 1fa8f94 into mui:next Apr 9, 2019
@eps1lon eps1lon deleted the test/types/button-styled branch April 9, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants