-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Remove babel-node for server/shared modules #15764
Conversation
Details of bundle changes.Comparing: f14ab42...6e55b5d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. At least we can see at the module system if a module is for the server/shared or client.
I fail to see how this change will provide value (it needs time to migrate, time we could spend on something else, after the change, we will try to write an import, if it doesn't work, we will try a require, I don't know when one should be used over the other, it's inconsistent, do we have a quantification of the overhead, 15%?). But I don't want to weight more than giving my "feeling" on the topic (I have fewer context than you). We can't improve without undertaking actions. |
Not sure how the time argument applies after the time has been invested. The rest is outlined in the original issue (startup time, debugging). |
@cvanem Thanks. Will come in handy later. Direct benefit isn't that obvious but it will pay off. |
#15497 (comment)
Replaces script usage of babel-node with node. With the exception of:
docs:api - This links into material-ui package code.
docs:i18n - Errors without babel-node. Looks like this relies on BABEL_ENV=test to resolve module paths.