-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Add fontWeightBold as 700(default) #16008
Conversation
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% Details of bundle changes.Comparing: 21582fd...f39c477
|
The failure is because I changed 600 to Strong and added fontWeightBold wherever necessary. Otherwise I think it is much better to use this way of define fontWeights. |
@eps1lon what are your thoughts on this PR? |
@aditya1906 It's a great start! I have tried to push it one step further. Let me push the changes. Unfortunately, I can't do it here as you have removed the remote branch: Let's continue the changes in #16036. This initial effort was continued in #16038 by @merceyz. It supersedes the initial request. Instead, we can recycle the remote branch :). |
Okay @oliviertassinari surely We can do that |
I'm extremely sorry that I accidentally deleted that branch |
@aditya1906 Don't worry about it, we learn by doing things wrong :). |
Thanks @oliviertassinari :-) |
Closes #15801