Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add fontWeightBold as 700(default) #16008

Closed
wants to merge 1 commit into from
Closed

[core] Add fontWeightBold as 700(default) #16008

wants to merge 1 commit into from

Conversation

aditya1906
Copy link
Contributor

@aditya1906 aditya1906 commented Jun 3, 2019

Closes #15801

@mui-pr-bot
Copy link

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%

Details of bundle changes.

Comparing: 21582fd...f39c477

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +Infinity% 🔺 +Infinity% 🔺 0 316,964 0 86,920
@material-ui/core/Paper +Infinity% 🔺 +Infinity% 🔺 0 67,963 0 20,209
@material-ui/core/Paper.esm +Infinity% 🔺 +Infinity% 🔺 0 61,258 0 19,006
@material-ui/core/Popper +Infinity% 🔺 +Infinity% 🔺 0 28,728 0 10,344
@material-ui/core/Textarea +Infinity% 🔺 +Infinity% 🔺 0 5,513 0 2,378
@material-ui/core/TrapFocus +Infinity% 🔺 +Infinity% 🔺 0 3,755 0 1,575
@material-ui/core/styles/createMuiTheme +Infinity% 🔺 +Infinity% 🔺 0 16,016 0 5,821
@material-ui/core/useMediaQuery +Infinity% 🔺 +Infinity% 🔺 0 2,106 0 974
@material-ui/lab +Infinity% 🔺 +Infinity% 🔺 0 138,361 0 42,531
@material-ui/styles +Infinity% 🔺 +Infinity% 🔺 0 51,384 0 15,191
@material-ui/system +Infinity% 🔺 +Infinity% 🔺 0 14,463 0 4,181
Button +Infinity% 🔺 +Infinity% 🔺 0 83,943 0 25,492
Modal +Infinity% 🔺 +Infinity% 🔺 0 20,341 0 6,686
colorManipulator +Infinity% 🔺 +Infinity% 🔺 0 3,904 0 1,543
docs.landing +Infinity% 🔺 +Infinity% 🔺 0 55,371 0 13,914
docs.main +Infinity% 🔺 +Infinity% 🔺 0 649,770 0 205,095
packages/material-ui/build/umd/material-ui.production.min.js +Infinity% 🔺 +Infinity% 🔺 0 290,843 0 83,155

Generated by 🚫 dangerJS against f39c477

@aditya1906
Copy link
Contributor Author

The failure is because I changed 600 to Strong and added fontWeightBold wherever necessary. Otherwise I think it is much better to use this way of define fontWeights.

@aditya1906
Copy link
Contributor Author

@eps1lon what are your thoughts on this PR?

@oliviertassinari
Copy link
Member

@aditya1906 It's a great start! I have tried to push it one step further. Let me push the changes. Unfortunately, I can't do it here as you have removed the remote branch:
Capture d’écran 2019-06-04 à 12 42 52

Let's continue the changes in #16036. This initial effort was continued in #16038 by @merceyz. It supersedes the initial request. Instead, we can recycle the remote branch :).

@aditya1906
Copy link
Contributor Author

Okay @oliviertassinari surely We can do that

@aditya1906
Copy link
Contributor Author

I'm extremely sorry that I accidentally deleted that branch

@oliviertassinari
Copy link
Member

@aditya1906 Don't worry about it, we learn by doing things wrong :).

@aditya1906
Copy link
Contributor Author

Thanks @oliviertassinari :-)

@zannager zannager added the core Infrastructure work going on behind the scenes label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CssBaseline] Strong/B tag font weight is being set to 500
4 participants